Fix spark installation for Java 11 and Arrow#1198
Merged
romainx merged 1 commit intojupyter:masterfrom Dec 26, 2020
Merged
Conversation
romainx
added
the
type:Bug
Collaborator
Author
|
Hello, I'm merging it since it's a bug fix. We will rollback in case of problem. Best. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Fixes #1168.
It consists in applying the fix described in the Spark downloading instructions:
The only problem of this solution is how it fits with other versions of Spark / Java that can be changed at build time through
ARGS. However I have tested with Java 8 and tests are passing, Spark 2.x does not work with Python 3.8, see apache/spark#26194, so I'm not sure it's worth going further on this compatibility point.I've added a specific test to ensure that the issue is fixed.
Best